Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phase2.md Add/refactor information about Data Types #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frozenfrank
Copy link
Contributor

Overview

This represents a draft proposal for ways we could improve the handling of data types, especially with students coming from a background in interpreted languages in mind.

This expands and improves upon the changes from #29.

Discussion

With the addition of explicit instruction about data types, it becomes reasonable to remove the comments about data types from the actual "Data Format" specification.

This edition provides examples, discussion about sizing consideration, and links to official documentation to help illuminate the importance of attention to data types in general.

This edition still clearly provides the answer about which data type to use along with a discussion about pros and cons of different definitions of the data type. I feel this is reasonable since this "Scientific Computing" is not designed to test student's knowledge of data types, although learning more about them along the way is a plus.

Anticipated Requests

The reviewers may want to suggest or contribute the following adjustments before completing this PR:

  • Moving this content to a "reading" page where it may be more appropriate
  • Removing the explicit declaration of the exact data type needed in favor of additional context to equip students to make the decision themselves
  • Adjusting the verbiage or formatting of the material

Reviewers

@paigeid-orc What do you think about this?

@frozenfrank frozenfrank self-assigned this Oct 24, 2024
@paigeid-orc
Copy link
Contributor

I don't think we actually want to put all this in phase2.md. We changed the type and I think that's enough on this page. If you really feel strongly about including this information, create a new page for this and link to it from our Resources page.

@frozenfrank
Copy link
Contributor Author

frozenfrank commented Nov 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants